emmanuel/gclc-core
emmanuel/gclc-core
1
0
Fork 0
Code Issues 2 Pull Requests Projects 1 Releases Wiki Activity

[fix] Fix use of computeIfPresent with HashMap with possible null values

Browse Source 
Signed-off-by: Emmanuel Bigeon <emmanuel@bigeon.fr>
This commit is contained in:
Emmanuel Bigeon 2021-11-07 12:22:11 +01:00
parent ea01d346d3
commit 625cacb198
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gclc/src/main/java/net/bigeon/gclc/command/CommandParameters.java
View File

@ -207,7 +207,11 @@ public final class CommandParameters {
* @param string the key
* @param value the value */
public void set(final String string, final String value) {
stringArguments.computeIfPresent(string,
(final String k, final String v) -> value);
// DO NOT USE computeIfPresent. This is a HashMap, not a ConcurrentHashMap and
// keys can be associated to null, but computeIfPresent will consider them as
// absent!
if (stringArguments.containsKey(string)) {
stringArguments.put(string, value);
}
}
}